[Lldb-commits] [PATCH] D83580: [lldb] on s390x fix override issue

[Konrad Wilhelm Kleine via Phabricator via lldb-commits]

kwk created this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

This fixes an override issue by marking a function as const so that the
signature maps to the signature of the function in the base class.

This is the original error:

In file included from 
/root/llvm/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.cpp:11:
/root/llvm/lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.h:79:10:
 error: 'size_t 
lldb_private::process_linux::NativeRegisterContextLinux_s390x::GetGPRSize()' 
marked 'override', but does not override

  79 |   size_t GetGPRSize() override { return sizeof(m_regs); }
     |          ^~~~~~~~~~


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D83580

Files:
  lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.h


Index: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.h
===================================================================
--- lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.h
+++ lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.h
@@ -76,7 +76,7 @@
   Status WriteFPR() override;
 
   void *GetGPRBuffer() override { return &m_regs; }
-  size_t GetGPRSize() override { return sizeof(m_regs); }
+  size_t GetGPRSize() const override { return sizeof(m_regs); }
   void *GetFPRBuffer() override { return &m_fp_regs; }
   size_t GetFPRSize() override { return sizeof(m_fp_regs); }
 



Index: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.h
===================================================================
--- lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.h
+++ lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_s390x.h
@@ -76,7 +76,7 @@
   Status WriteFPR() override;
 
   void *GetGPRBuffer() override { return &m_regs; }
-  size_t GetGPRSize() override { return sizeof(m_regs); }
+  size_t GetGPRSize() const override { return sizeof(m_regs); }
   void *GetFPRBuffer() override { return &m_fp_regs; }
   size_t GetFPRSize() override { return sizeof(m_fp_regs); }
 

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits