JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.
================
Comment at: lldb/packages/Python/lldbsuite/test/lldbinline.py:209
test_class = type(name, (InlineTest,), dict(test=test_func,
- name=name, _build_dict=build_dict))
+ name=name, __inline_name__=name, _build_dict=build_dict))
----------------
labath wrote:
> `__inline_name__` is not a good name according to
> <https://www.python.org/dev/peps/pep-0008/>:
> ```
> __double_leading_and_trailing_underscore__: "magic" objects or attributes
> that live in user-controlled namespaces. E.g. __init__, __import__ or
> __file__. Never invent such names; only use them as documented.
> ```
>
I did it for consistency with `__no_debug_info_test__`. Based on that PEP we
should rename it to `__no_debug_info_test`?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D81516/new/
https://reviews.llvm.org/D81516
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
