labath marked an inline comment as done. labath added inline comments.
================ Comment at: lldb/include/lldb/Symbol/Function.h:332 - /// The address of the call instruction. Usually an invalid address, unless - /// this is a tail call. - lldb::addr_t call_inst_pc; + bool caller_address_type : 1, is_tail_call : 1; ---------------- vsk wrote: > It seems like there's going to be around sizeof(void *) bytes worth of > padding here. Maybe it'd be simpler to store these flags as AddrType and bool > respectively? Alternatively, the struct can be marked 'packed'. Indeed. I was optimizing prematurely. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81010/new/ https://reviews.llvm.org/D81010 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
