teemperor marked an inline comment as done.
teemperor added a comment.
In D80308#2051624 <https://reviews.llvm.org/D80308#2051624>, @aprantl wrote:
> > It seems C++17 and so on isn't yet in any of the language enums (and the
> > DWARF standard it seems), so C++17 support will be a follow up patch.
>
> Yes and that may point to a problem with this approach. IIRC, there is — on
> purpose — no C++17 language constant because the committee didn't see the
> need to differentiate it in DWARF, since all features were additive and could
> be described through specific C++17-related attributes.
Interesting, so DWARF will do 11, 14, <skip>, 20? And 17 will presumably be
encoded as 14 in DWARF?
================
Comment at: lldb/test/API/lang/cpp/standards/cpp14/TestCPP14Standard.py:19
+ # polymorphic lambdas).
+ self.expect_expr("[](auto x) { return x; }(1)", result_type="int",
result_value="1")
----------------
shafik wrote:
> It would be worth it to add a more complete set of C++14 tests.
> [p1319r0](http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p1319r0.html)
> covers the C++11 to C++14 differences.
>
> Especially ones that may not work so we can file bugs for these and track
> them.
We're only checking that the right Clang language standard was set, not Clang's
C++ features related to that set standard (which should be and probably already
is a test in Clang).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80308/new/
https://reviews.llvm.org/D80308
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
