vsk added a comment.
Thanks! LGTM, modulo any comments Raphael may have about the test change.
================
Comment at: lldb/packages/Python/lldbsuite/test/lldbinline.py:155
process, lldb.eStopReasonBreakpoint)
- breakpoint_id = thread.GetStopReasonDataAtIndex(0)
- parser.handle_breakpoint(self, breakpoint_id)
+ for id in self._get_breakpoint_ids(thread):
+ parser.handle_breakpoint(self, id)
----------------
nit: I think this leaves the 'id' builtin defined as the last breakpoint id
after the loop is done, maybe name it something else ('breakpoint_id'?).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79563/new/
https://reviews.llvm.org/D79563
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
