labath added a comment. Well... this is closer, but we should get rid of the Module argument. It's not consistent with the other SymbolFile functions, and also not necessary...
================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:784-793 + // Register the sysroot path remapping with this symbol file's module. + if (ModuleSP module_sp = m_objfile_sp->GetModule()) + if (module_sp.get() != module) + module_sp->RegisterXcodeSDK(sdk, sysroot); + // Register the sysroot path remapping with the module that + // was passed in. The two would be different if this is an OSO + // object and module is the corresponding debug map., in which ---------------- I don't think you need to pass thread the Module argument everywhere. The module you want should be available as comp_unit.GetModule(). `SymbolFileDWARFDebugMap::ParseCompileUnitAtIndex` ensures that the CUs are created pointing to the "main" module. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79384/new/ https://reviews.llvm.org/D79384 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
