mib marked 2 inline comments as done. mib added inline comments.
================ Comment at: lldb/source/Host/common/FileSystem.cpp:504 + FileSpec file(file_path.getSingleStringRef()); + return Readable(file_path) && Instance().Open(file, File::eOpenOptionRead); +} ---------------- shafik wrote: > Since `file` is a `FileSpec` can't we just use `ReadableByCurrentUser(const > FileSpec &file_spec) ` here? Good catch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78712/new/ https://reviews.llvm.org/D78712 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits