jankratochvil marked 2 inline comments as done. jankratochvil added inline comments.
================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.h:82 + /// The object will remain valid during the whole call statement: + /// Function(name, DIERefCallback({callback, name})); + struct DIERefCallbackArgs { ---------------- This calling with curly brackets is a bit tricky but I found it the least worst option. ================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.h:93 + + void ReportInvalidDIERef(DIERef ref, llvm::StringRef name) const; }; ---------------- Invalid `DIERef` is now reported for all Indexes, not just `AppleDWARFIndex`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77970/new/ https://reviews.llvm.org/D77970 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits