labath added a reviewer: jasonmolenda.
labath added a comment.

I am still thinking this over, but for now I have two comments. First, could 
you re-upload the diff with full context (e.g. `git show -U9999`). That would 
make it a lot easier to review this.
Second, would it be possible to change the meaning of the `invalidate_regs` and 
`value_regs` lists so that they do the right thing even in your case (instead 
of introducing a new number)? We already have too many numbering schemes to 
begin with, and introducing a new one is definitely something I'd like to avoid 
(in particular when the number is stored as `eRegisterKindLLDB` on the server 
side, but then becomes `eRegisterKindProcessPlugin` on the other end).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77043/new/

https://reviews.llvm.org/D77043



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to