labath marked 4 inline comments as done.
labath added inline comments.
================
Comment at: lldb/source/Host/windows/ProcessLauncherWindows.cpp:41
+ // double null.
+ if (env.empty()) {
+ buffer.push_back(0);
----------------
amccarth wrote:
> There would be no harm in always adding the extra terminator.
Yeah, I wondered myself what would be less confusing... inserting a seemingly
needless terminator, or cluttering the code with an extra if...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76835/new/
https://reviews.llvm.org/D76835
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
