labath added a comment. In D76805#1944198 <https://reviews.llvm.org/D76805#1944198>, @emrekultursay wrote:
> > Does this actually depend on the other patch? It looks like an independent > > fix we could commit separately. > > This bug seems to have existed forever. Fixing it means we will have source > file cache enabled for the first time. If it causes any unforeseen issues, > I'd like users to have the ability to disable the cache, which is why I made > this change depend on the other change. Ok, that makes kind of sense, though I am left wondering if we really need this feature, given that we have survived so long without noticing it is missing... Am I understanding it correctly that without this patch, we would only cache the most recently accessed file (via `m_last_file_sp` member), and would always reload when switching to a new file? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76805/new/ https://reviews.llvm.org/D76805 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
