labath added a comment.

Ok, you really want to collect the full dsym, then who am I to stop you. :)

But implementing that collection in the FileCollector does not seem right, 
because at the filesystem level, dsyms are not special (which is why you needed 
to reverse-engineer them from the path). Maybe if we create some sort of an API 
to register files/directories of "special interest", then we could have 
something (`SymbolVendorMacOSX`, most likely) call it to record the full dsym 
when it knows it has encountered it.

Then we could have a similar api to register files of special **dis**interest, 
which could be used to selectively omit things from the reproducer. That part 
may be also interesting for using reproducers internally at google, because the 
binaries there are too big to be shipped around all the time.


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76672/new/

https://reviews.llvm.org/D76672



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to