HsiangKai added a comment. In D74023#1938583 <https://reviews.llvm.org/D74023#1938583>, @jhenderson wrote:
> In D74023#1937220 <https://reviews.llvm.org/D74023#1937220>, @HsiangKai wrote: > > > In D74023#1933427 <https://reviews.llvm.org/D74023#1933427>, @jhenderson > > wrote: > > > > > @HsiangKai, have you noticed that there are some test failures according > > > to the harbourmaster bot? They look like they could be related to this > > > somehow. > > > > > > @jhenderson, yes, I found test failures in harbormaster. The failures are > > occurred after I rebased my patch on master branch. After digging into > > error messages, I found the failures are triggered by find_if(). Maybe I > > misuse find_if() in this patch? Do you have any idea about this? > > By the way, I also found some patch, D75015 > > <https://reviews.llvm.org/D75015>, landed even harbormaster is failed. I am > > curious about is it a necessary condition to pass harbormaster before > > landing? > > > I don't have much understanding of how Harbormaster works, and it may be that > the failures are unrelated to anything you did, since I believe it just > applies your patch on top of the current HEAD of master, which might not work > for various reasons. Still, it's worth reviewing and locally checking the > same tests to make sure they aren't failing locally. If you review the logs > produced, you might spot an issue. If Harbormaster is failing for a reason > related to your patch, your patch will almost certainly cause build bot > failures, so in that case, it is necessary to fix the issues (but in other > cases, if the issues are unrelated, it isn't). > > As for why find_if isn't working, I don't know, and I'd suggest you debug it. Thanks for your reply. I will try to figure out why Harbormaster is failed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74023/new/ https://reviews.llvm.org/D74023 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
