labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
This is great. The new test looks even better than I had hoped for. Thanks for
sticking with this.
================
Comment at:
lldb/packages/Python/lldbsuite/test/tools/lldb-server/threads-info/main.cpp:1
+#include <cstdint>
+
----------------
I don't believe this include is needed.
================
Comment at:
lldb/packages/Python/lldbsuite/test/tools/lldb-server/threads-info/main.cpp:3
+
+int main() {
+#if defined(__x86_64__)
----------------
Maybe a short intro (here or on the test) which states that this constructs
some artificial stack frames to test the frame-pointer following code in
lldb-server.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74398/new/
https://reviews.llvm.org/D74398
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
