jhenderson added inline comments.
================
Comment at: llvm/test/DebugInfo/X86/dwp-v5-cu-index.s:1
+## The test checks that we can parse and dump a CU index section that compliant
+## to the DWARFv5 standard.
----------------
that is compliant
================
Comment at: llvm/test/DebugInfo/X86/dwp-v5-tu-index.s:1
+## The test checks that we can parse and dump a TU index section that compliant
+## to the DWARFv5 standard.
----------------
that is compliant
================
Comment at: llvm/tools/llvm-dwp/llvm-dwp.cpp:614
+ if (CUIndex.getVersion() != 2)
+ return make_error<DWPError>("Unsupported cu_index version");
----------------
jhenderson wrote:
> I see the above error message starts with a capital letter, but more
> generally I think we try to use lower-case for error messages. Maybe worth
> doing it right here and changing the above line in a separate change?
Ping?
================
Comment at: llvm/tools/llvm-dwp/llvm-dwp.cpp:653
+ if (TUIndex.getVersion() != 2)
+ return make_error<DWPError>("Unsupported tu_index version");
addAllTypesFromDWP(
----------------
jhenderson wrote:
> Same comment as above.
Ping?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75929/new/
https://reviews.llvm.org/D75929
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
