shafik added inline comments.
================ Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp:1374 + // Number of time the previous character is repeated. + int repeat_count = *++c + 3 - ' '; + // We have the char_to_repeat and repeat_count. Now push it in the ---------------- This line feels cryptic. Why `3` and `' '`. Maybe two lines would be better, still have to think carefully about order of operations too. The code is using three representations for characters: char literals, raw integers and hex. Maybe use hex everywhere would be more consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76163/new/ https://reviews.llvm.org/D76163 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
