aprantl added a comment.

Thanks for sharing your thoughts! Moving to a type-safe subclass does make 
sense, I don't think that calling the verifier there is the best choice. For 
example, if I'm calling `CompilerType::GetPointerType(CompilerType pointee)` 
I'd want the resulting type verified, too. Then again, if the implementation of 
that function calls the specialized constructor, that might be good enough.

As for null types; In swift-lldb they are constructed quite a lot, mostly as 
default and "error" return values from type system operations. There is 
probably no need for more than one kind of null type though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76011/new/

https://reviews.llvm.org/D76011



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to