[Lldb-commits] [PATCH] D75761: [lldb] Fix to get the AST we generate for function templates to be closer to what clang generates and expects

[Raphael Isemann via Phabricator via lldb-commits]

teemperor accepted this revision.
teemperor added a comment.

LGTM



================
Comment at: lldb/test/API/lang/cpp/template-function/TestTemplateFunctions.py:37
+          self.expect_expr("var(1)", result_type="int", result_value="10")
+          self.expect_expr("var(1,2)", result_type="int", result_value="10")
+
----------------
ultra nit pick: technically there should be a space after the "," in the 
expression.


================
Comment at: lldb/test/API/lang/cpp/template-function/main.cpp:6
 
+// Some cases to cover ADL, we hae two cases:
+//
----------------
hae -> have


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75761/new/

https://reviews.llvm.org/D75761



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits