jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed.
Thanks for doing this, it will be useful! I'll let Jonas comment on whether the Reproducer bindings are right, though it looks fine to me. One of the very common uses of an SBEnvironment is the one in an SBTarget, which gets used to create new processes. With what you have you can get access to it, so that's all good. But you do it by getting the target's platform, and then the Environment from the platform. It might be more discoverable to have the SBTarget hand it out directly as well, however. And there is an lldb_private::Target::GetEnvironment, so it's pretty natural. Also, you need some tests. You can probably do a lot of it with unit tests. Then maybe a small API test that sets environment variables and fetches them out this way and checks that they are right. The added API's are up to you. The requested changes are for tests... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76111/new/ https://reviews.llvm.org/D76111 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
