labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
sounds reasonable. ================ Comment at: lldb/include/lldb/API/SBTarget.h:130-132 + /// The environment array. If this isn't provided, the default + /// environment values (provided through `settings set + /// target.env-vars`) will be used. ---------------- Make it explicit that "isn't provided" means nullptr. And maybe mention that one can get an empty environment by passing an empty array. And do the same for the argv array. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76045/new/ https://reviews.llvm.org/D76045 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
