labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
Another option might be to make TargetProperties a member instead of a base class. I don't think the current setup makes for a particularly clean design. If `TargetProperties` is among the last Target members being initialized, then calling the callbacks from the constructor should "just work". ================ Comment at: lldb/include/lldb/Target/Target.h:214 + void RunCallbacks(); + ---------------- This name is very nondescript. I think it would be better to name this according to what it does, instead of how it does it. `LoadDefaultPropertyValues()` ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76009/new/ https://reviews.llvm.org/D76009 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
