JDevlieghere marked 7 inline comments as done.
JDevlieghere added inline comments.
================
Comment at: lldb/source/Utility/ProcessInfo.cpp:417-430
+ static std::unique_ptr<repro::MultiLoader<repro::ProcessInfoProvider>>
+ loader = repro::MultiLoader<repro::ProcessInfoProvider>::Create(
+ repro::Reproducer::Instance().GetLoader());
+
+ if (!loader)
+ return {};
+
----------------
labath wrote:
> random thought: Would any of this be simpler if this wasn't a "multi"
> provider but rather stored all of the responses as a sequence in a single
> file?
Maybe/Probably? I'm not sure. But even if it were a bit simpler, I think it's
better to reuse the existing multi-provider for consistency.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75877/new/
https://reviews.llvm.org/D75877
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
