teemperor added inline comments.
================ Comment at: lldb/include/lldb/Symbol/Type.h:198 uint32_t GetEncodingMask(); - - bool IsCompleteObjCClass() { return m_is_complete_objc_class; } - - void SetIsCompleteObjCClass(bool is_complete_objc_class) { - m_is_complete_objc_class = is_complete_objc_class; - } + uint32_t &GetPayload() { return m_payload; } ---------------- Remove reference? ================ Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.h:91 DeclContextToDIEMap m_decl_ctx_to_die; + DIEToModuleMap m_die_to_module; std::unique_ptr<lldb_private::ClangASTImporter> m_clang_ast_importer_up; ---------------- Maybe I'm missing something but this is `DIEToModuleMap` but it seems the value in this map is actually a module **ID** and not a module **map**? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75488/new/ https://reviews.llvm.org/D75488 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits