teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land.
The changes that remove the non-existent module parameter slipped in by mistake I think and the rest LGTM. I didn't verify if all the `setX` calls are 100% identical to what the constructor would do but *usually* Decl constructor don't any fancy logic so the new code should be equivalent. Maybe dump some module AST before and after this patch and just diff it to see if anything changed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75715/new/ https://reviews.llvm.org/D75715 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
