JDevlieghere added inline comments.
================
Comment at: lldb/source/API/SBThread.cpp:361-363
stop_desc =
exe_ctx.GetProcessPtr()->GetUnixSignals()->GetSignalAsCString(
stop_info_sp->GetValue());
----------------
friss wrote:
> I don't think this is generally safe. Creating a `std::string` from a nullptr
> is undefined (and the previous test makes it look like this pointer could be
> null).
`GetStopDescription` now returns a `std::string`, so it should be fine here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74096/new/
https://reviews.llvm.org/D74096
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
