anton.kolesov added a comment.

My original patch was changing lldb-vscode - it was creating a new Target 
object with ELF given to a constructor. That patch, though definitely would 
need an update - it should delete the original empty target after creating the 
new one, but it was leaving it alive. To me this solution looks preferable, 
because I'm a fanboy for immutable objects in general, and in this specific 
case I don't fully understand all of the potential side effects of the 
SetExecutable call.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70847/new/

https://reviews.llvm.org/D70847



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to