labath added a comment.

Thanks for the patch, and in particular for starting with a small increment 
instead of a giant implement-all patch.

Could you please add a simple test case that runs `yaml2obj | lldb-test 
object-file` and verifies that the avr object file is parsed properly. (The 
architecture is the most important part, but you might as well check the 
sections while you're at it.) You can look at the existing tests in 
`test/Shell/ObjectFile` for inspiration.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73539/new/

https://reviews.llvm.org/D73539



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to