diazhector98 planned changes to this revision.
diazhector98 marked 5 inline comments as done.
diazhector98 added inline comments.
================
Comment at:
lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/completions/TestVSCode_completions.py:122
+ self.verify_completions(
+ self.vscode.get_completions("foo1.v"),
+ [
----------------
also test this
foo.var1 + var2
foo.var1 + va
var2
var1
================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:956
+
+ std::vector<std::string> breakpoints = {".", "->"};
+ int max_breakpoint_position = -1;
----------------
commit_points
================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:958
+ int max_breakpoint_position = -1;
+ std::string breakpoint_string = "";
+ for (std::string breakpoint : breakpoints){
----------------
int breakpoint_index = -1
================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:959
+ std::string breakpoint_string = "";
+ for (std::string breakpoint : breakpoints){
+ int breakpoint_position = match.rfind(breakpoint);
----------------
space before {
================
Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:966
+ }
+ if (max_breakpoint_position != -1){
+ std::string cut_match = match.substr(max_breakpoint_position +
breakpoint_string.length(), match.length() - max_breakpoint_position);
----------------
space before {
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73506/new/
https://reviews.llvm.org/D73506
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
