labath added a comment.

Thanks. I am glad that we were able to sort that out.

Now that there's nothing wasm-specific in 
`DynamicLoaderWasmDYLD::LoadModuleAtAddress`, I have another question. :)

The code in that function is a subset of the base 
`DynamicLoader::LoadModuleAtAddress` method you are overriding.  Is there a 
reason for that?
It doesn't seem like the additional stuff in the base method should hurt here. 
What the additional code does is that it tries to search for the object file on 
the local filesystem, and if it finds it, it will use that instead of copying 
the file over from the remote. In fact, that sounds like it could be useful 
here too, as copying that much data over gdb-remote isn't particularly fast..

What do you think about that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72751/new/

https://reviews.llvm.org/D72751



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to