clayborg added a comment.

Would it be better to just ensure that the buffer for DW_OP_piece is at least 
the size of the type instead? To do this right we would really need to track 
which bytes in the buffer are actually valid. This patch assumes we will always 
get the first N bytes of a value. Is it possible to describe bytes 4:7 of a 16 
bit value where bits 0:3 and 8:15 are not valid? In this case, with this patch, 
we would think that bytes 0:3 are valid when they are just not specified, 4:7 
would be valid, and 8:15 would not display because our value doesn't contain 
the value.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73148/new/

https://reviews.llvm.org/D73148



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to