labath added a comment.

Since the initialization function will have to have predictable names anyway, 
instead of generating the `#include` directives, we could just automatically 
forward declare the needed functions. So, the .def file would expand to 
something like:

  extern lldb_initialize_objectfile_elf();
  lldb_initialize_objectfile_elf();
  extern lldb_initialize_objectfile_macho();
  lldb_initialize_objectfile_macho();
  ...

That way we would have only one generated file, and we could ditch the 
`Initialization.h` file for every plugin (which would contain just the two 
forward declarations anyway). And this approach would be pretty close to what 
we'd need to do for dynamically loaded plugins (where instead of an extern 
declaration we'd have a dlsym lookup).


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73067/new/

https://reviews.llvm.org/D73067



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to