unnar added a comment. In D72909#1826110 <https://reviews.llvm.org/D72909#1826110>, @labath wrote:
> Thanks for the patch. I've been wondering how to improve this, and this > solution is pretty neat. > > I have just one request. Instead of the `ReplaceLineTableWithSequences` > thingy, could you just create a LineTable constructor, which takes an > `ArrayRef<LineSequence *>` or similar. It looks like all it takes is to make > `CreateLineSequenceContainer` static, so you can invoke it without a > `LineTable` instance. (There are other possible cleanups here too, but I > don't think its your job do fix all of those...) Thanks for the quick review! It also requires AppendLineEntryToSequence to be static but I assume that should also be just fine. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72909/new/ https://reviews.llvm.org/D72909 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
