aprantl added inline comments.
================
Comment at: lldb/test/Shell/lit.cfg.py:42-46
if 'LLDB_CAPTURE_REPRODUCER' in os.environ:
config.environment['LLDB_CAPTURE_REPRODUCER'] = os.environ[
'LLDB_CAPTURE_REPRODUCER']
+if 'LLDB_REPRO_CAPTURE' in os.environ:
+ config.environment['LLDB_REPRO_CAPTURE'] = os.environ['LLDB_REPRO_CAPTURE']
----------------
JDevlieghere wrote:
> labath wrote:
> > The difference between these two is super-unclear. Any chance to unify them?
> Not really, one is for the tool, the other is to enable reproducer capture by
> default. They're totally orthogonal, but I agree it's confusing.
How about adding this as a comment here?
================
Comment at: lldb/tools/lldb-repro/lldb-repro.cpp:25
+ const unsigned hash = djbHash(cwd);
+ return djbHash(args, hash);
+}
----------------
`hash_combine()`?
================
Comment at: lldb/tools/lldb-repro/lldb-repro.h.cmake:5
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
----------------
Out of curiosity, is the `Copyright 2020` line part of the recommended default
file header?
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72823/new/
https://reviews.llvm.org/D72823
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
