SouraVX added a comment. In D72597#1819164 <https://reviews.llvm.org/D72597#1819164>, @labath wrote:
> I have a high-level question/comment. Are you planning to implement > debug_macro reading in llvm-dwarfdump? Even if you aren't, I am expecting > that you will be asked to do that as a part of testing for your debug_macro > generation patch... Hi Pavel, I've mostly completed debug_macro generation[clang/llvm] and dumping it using llvm-dwarfdump. I'll soon file a review for that also. Maybe we can address this concern while reviewing that. Till that, I think it would be nice to have minimum support for macros. > And in that case, it would be much better to write a debug_macro parser in > first, and reuse that in lldb, similar to how its done for rnglists, > loclists, and other "minor" sections. The slightly tricky part there is that > you need to make sure to not intertwine it too much with other llvm dwarf > classes, as lldb does not use all of llvm dwarf (yet). However, given that > the debug_macro section is pretty independent, that shouldn't be too much of > a problem? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72597/new/ https://reviews.llvm.org/D72597 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
