shafik added a comment.
Perhaps it makes sense to modify the `dump()` method to also display the new
name?
================
Comment at:
lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:609
+ m_ast_context.reset(new ClangASTContext(
+ "Expression AST for '" + m_filename + "'", ast_context));
----------------
AST -> ASTContext?
================
Comment at:
lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp:164
+ m_ast_context.reset(new ClangASTContext(
+ "ClangModulesDeclVendor AST", m_compiler_instance->getASTContext()));
}
----------------
AST -> ASTContext?
================
Comment at:
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCDeclVendor.cpp:147
+ m_ast_ctx(
+ "AppleObjCDeclVendor AST",
+ runtime.GetProcess()->GetTarget().GetArchitecture().GetTriple()),
----------------
AST -> ASTContext?
Below you use "scratch ASTContext"
================
Comment at:
lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTypeEncodingParser.cpp:27
+ m_scratch_ast_ctx_up.reset(new ClangASTContext(
+ "AppleObjCTypeEncodingParser AST",
+ runtime.GetProcess()->GetTarget().GetArchitecture().GetTriple()));
----------------
AST -> ASTContext?
================
Comment at: lldb/unittests/Symbol/TestClangASTContext.cpp:29
void SetUp() override {
- m_ast.reset(new ClangASTContext(HostInfo::GetTargetTriple()));
+ m_ast.reset(new ClangASTContext("test AST", HostInfo::GetTargetTriple()));
}
----------------
AST -> ASTContext?
================
Comment at: lldb/unittests/SymbolFile/DWARF/DWARFASTParserClangTests.cpp:42
EnsureAllDIEsInDeclContextHaveBeenParsedParsesOnlyMatchingEntries) {
- ClangASTContext ast_ctx(HostInfoBase::GetTargetTriple());
+ ClangASTContext ast_ctx("dummy", HostInfoBase::GetTargetTriple());
DWARFASTParserClangStub ast_parser(ast_ctx);
----------------
dummy -> dummy ASTContext
================
Comment at: lldb/unittests/TestingSupport/Symbol/ClangTestUtils.h:25
inline std::unique_ptr<ClangASTContext> createAST() {
- return std::make_unique<ClangASTContext>(HostInfo::GetTargetTriple());
+ return std::make_unique<ClangASTContext>("test AST",
+ HostInfo::GetTargetTriple());
----------------
AST -> ASTContext?
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72391/new/
https://reviews.llvm.org/D72391
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
