mib marked an inline comment as done.
mib added inline comments.
================
Comment at:
lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/TestWatchpointCommands.py:194-196
+ # Delete the watchpoint immediately using the force option.
+ self.expect("watchpoint delete --force",
+ substrs=['All watchpoints removed.'])
----------------
friss wrote:
> Can't we just add this to the end of another test without spinning up a new
> process?
>
> Did you verify that the test failed before your patch? I'm asking because I
> don't know what m_interpreter.Confirm() does when there's no PTY connected.
> Does it default to no or yes?
I merge both tests (`auto-confirm` enabled & `--force` flag) into one.
FWIU, m_interpreter.Confirm(message, default_answer) checks first the
auto-confirm setting, When enabled, it returns the default answer (true in this
case) otherwise, it triggers the IOHandler for the user input.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72096/new/
https://reviews.llvm.org/D72096
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
