jarin marked 7 inline comments as done.
jarin added a comment.
I have addressed the comments, thanks for the quick review.
================
Comment at: lldb/source/API/SBType.cpp:218
+ return LLDB_RECORD_RESULT(
+ SBType(TypeImplSP(new TypeImpl(canonical_type.GetArrayElementType()))));
}
----------------
teemperor wrote:
> I get that this is to preserve the previous SB API behavior but I think it's
> better if we keep this method a simple wrapper without extra functionality.
> That we return the canonical type seems like a bug for me, so it's IMHO fine
> to change this behavior.
Unfortunately, returning the non-canonicalized type breaks bunch of test (see
below). In any case, such change should be done in a separate patch.
lldb-api ::
functionalities/breakpoint/breakpoint_conditions/TestBreakpointConditions.py
lldb-api ::
functionalities/data-formatter/data-formatter-stl/libcxx/unordered/TestDataFormatterUnordered.py
lldb-api ::
functionalities/data-formatter/data-formatter-stl/libstdcpp/list/TestDataFormatterStdList.py
lldb-api ::
functionalities/data-formatter/refpointer-recursion/TestDataFormatterRefPtrRecursion.py
lldb-api ::
functionalities/data-formatter/varscript_formatting/TestDataFormatterVarScriptFormatting.py
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72133/new/
https://reviews.llvm.org/D72133
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
