Author: Saleem Abdulrasool Date: 2020-01-01T14:22:49-08:00 New Revision: fb170fd652bf2fcc4c2cd54aaf384591d8df266b
URL: https://github.com/llvm/llvm-project/commit/fb170fd652bf2fcc4c2cd54aaf384591d8df266b DIFF: https://github.com/llvm/llvm-project/commit/fb170fd652bf2fcc4c2cd54aaf384591d8df266b.diff LOG: tests: XFAIL/UNSUPPORTED tests on Windows Now that we are building the python bindings on Windows once more, the extended testsuite is running. Mark a few failing tests and skip a few tests which hang. This should at least bring the bot back to green without reverting the Python changes which are an improvement for the build system and enable another ~35% of the test suite which was previously disabled. Added: Modified: lldb/packages/Python/lldbsuite/test/commands/settings/TestSettings.py lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py lldb/packages/Python/lldbsuite/test/functionalities/dead-strip/Makefile lldb/packages/Python/lldbsuite/test/functionalities/dead-strip/TestDeadStrip.py lldb/packages/Python/lldbsuite/test/source-manager/TestSourceManager.py Removed: ################################################################################ diff --git a/lldb/packages/Python/lldbsuite/test/commands/settings/TestSettings.py b/lldb/packages/Python/lldbsuite/test/commands/settings/TestSettings.py index 3b9f64707bb4..1130821bac0f 100644 --- a/lldb/packages/Python/lldbsuite/test/commands/settings/TestSettings.py +++ b/lldb/packages/Python/lldbsuite/test/commands/settings/TestSettings.py @@ -58,6 +58,7 @@ def test_insert_before_and_after_target_run_args(self): '[3]: "b"', '[4]: "c"']) + @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr44430") def test_replace_target_run_args(self): """Test that 'replace target.run-args' works.""" # Set the run-args and then replace the index-0 element. @@ -106,6 +107,7 @@ def test_set_term_width(self): substrs=["term-width (int) = 70"]) # rdar://problem/10712130 + @skipIf(oslist=["windows"], bugnumber="llvm.org/pr44431") def test_set_frame_format(self): """Test that 'set frame-format' with a backtick char in the format string works as well as fullpath.""" self.build() @@ -356,6 +358,7 @@ def test_settings_with_quotes(self): 'thread-format (format-string) = "abc def "') self.runCmd('settings clear thread-format') + @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr44430") def test_settings_with_trailing_whitespace(self): # boolean diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py b/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py index 6f190ea4fbc9..77db8f745d7e 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py +++ b/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py @@ -22,6 +22,7 @@ def not_test_breakpoint_command_sequence(self): self.build() self.breakpoint_command_sequence() + @skipIf(oslist=["windows"], bugnumber="llvm.org/pr44431") def test_script_parameters(self): """Test a sequence of breakpoint command add, list, and delete.""" self.build() diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/dead-strip/Makefile b/lldb/packages/Python/lldbsuite/test/functionalities/dead-strip/Makefile index ea15ec84d685..3e7e139ddd60 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/dead-strip/Makefile +++ b/lldb/packages/Python/lldbsuite/test/functionalities/dead-strip/Makefile @@ -6,12 +6,13 @@ endif ifeq "$(OS)" "Darwin" LD_EXTRAS = -Xlinker -dead_strip -else ifeq "$(OS)" "Windows_NT" - CFLAGS_EXTRAS += /Gw /Gy - LD_EXTRAS = -Xlinker /OPT:REF else CFLAGS_EXTRAS += -fdata-sections -ffunction-sections - LD_EXTRAS = -Wl,--gc-sections + ifeq "$(OS)" "Windows_NT" + LD_EXTRAS = -Xlinker /OPT:REF + else + LD_EXTRAS = -Wl,--gc-sections + endif endif MAKE_DSYM := NO diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/dead-strip/TestDeadStrip.py b/lldb/packages/Python/lldbsuite/test/functionalities/dead-strip/TestDeadStrip.py index cb610697807d..bc1f3f8003f3 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/dead-strip/TestDeadStrip.py +++ b/lldb/packages/Python/lldbsuite/test/functionalities/dead-strip/TestDeadStrip.py @@ -14,6 +14,7 @@ class DeadStripTestCase(TestBase): mydir = TestBase.compute_mydir(__file__) + @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr44429") def test(self): """Test breakpoint works correctly with dead-code stripping.""" self.build() diff --git a/lldb/packages/Python/lldbsuite/test/source-manager/TestSourceManager.py b/lldb/packages/Python/lldbsuite/test/source-manager/TestSourceManager.py index 6831e9983692..f91d07602775 100644 --- a/lldb/packages/Python/lldbsuite/test/source-manager/TestSourceManager.py +++ b/lldb/packages/Python/lldbsuite/test/source-manager/TestSourceManager.py @@ -171,6 +171,7 @@ def test_move_and_then_display_source(self): self.expect("source list -n main", SOURCE_DISPLAYED_CORRECTLY, substrs=['Hello world']) + @skipIf(oslist=["windows"], bugnumber="llvm.org/pr44431") def test_modify_source_file_while_debugging(self): """Modify a source file while debugging the executable.""" self.build() @@ -236,6 +237,7 @@ def test_modify_source_file_while_debugging(self): SOURCE_DISPLAYED_CORRECTLY, substrs=['Hello lldb']) + @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr44432") def test_set_breakpoint_with_absolute_path(self): self.build() hidden = self.getBuildArtifact("hidden") _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits