mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land.
Besides missing LZMA, looks good to me. However, I suspect you may want to wait for a second opinion ;-). ================ Comment at: lldb/cmake/modules/LLDBConfig.cmake:410 find_package(LibLZMA) cmake_dependent_option(LLDB_ENABLE_LZMA "Support LZMA compression" ON "LIBLZMA_FOUND" OFF) if (LLDB_ENABLE_LZMA) ---------------- Did you omit `LLDB_ENABLE_LZMA` on purpose or accidentally? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71306/new/ https://reviews.llvm.org/D71306 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits