labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
In D71150#1778351 <https://reviews.llvm.org/D71150#1778351>, @rupprecht wrote: > In D71150#1774575 <https://reviews.llvm.org/D71150#1774575>, @labath wrote: > > > Hmm... given the lua thread on lldb-dev, maybe we should slow down here, > > and consider the potential relationship of these tests and the hypothetical > > lua tests that come to be. One of the reasons the current tests are so > > deeply nested was that Zach was trying to future-proof ourselves for > > addition of new scripting languages (at that time, Java was being floated > > around, but the idea never took off the ground). I'd hate to move these > > tests now, only to have to move them around again in a couple of weeks to > > make room for lua... > > > I don't *think* this patch is affected by that discussion, except for the > speculative comment to update `lldb_test_root = os.path.join(lldb_root, > "test", "API", "test")` with the next patch. I'll followup with the next > patch discussion. Yes, that seems reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71150/new/ https://reviews.llvm.org/D71150 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
