labath added a comment.

Not really my area, but it seems reasonable. One thing I'd consider is 
replacing the functions which return the values through a by-ref argument (e.g. 
`TypeCategoryMap::Get` with an actual return value. That'd mean one would have 
to type out the type in the invocation explicitly instead of relying on 
template argument deduction, but I don't think that's very useful, as one still 
has to spell out the type in the variable declaration on the preceding line..


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71231/new/

https://reviews.llvm.org/D71231



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to