Author: Muhammad Omair Javaid Date: 2019-12-09T19:08:59+05:00 New Revision: 0964733bae2d0823f7b431ee2b16a3fd1dd993e3
URL: https://github.com/llvm/llvm-project/commit/0964733bae2d0823f7b431ee2b16a3fd1dd993e3 DIFF: https://github.com/llvm/llvm-project/commit/0964733bae2d0823f7b431ee2b16a3fd1dd993e3.diff LOG: [lldb] Remove Xfail decorators from steadily passing tests This patch removes xfail decorator from some lldb testcases which are passing steadily now for past few week/months on aarch64/linux buildbot. Added: Modified: lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/command/TestWatchpointCommandLLDB.py lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/command/TestWatchpointCommandPython.py lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/condition/TestWatchpointConditionCmd.py lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_events/TestWatchpointEvents.py lldb/packages/Python/lldbsuite/test/functionalities/archives/TestBSDArchives.py lldb/packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentTwoWatchpointsOneSignal.py lldb/packages/Python/lldbsuite/test/lang/c/const_variables/TestConstVariables.py lldb/packages/Python/lldbsuite/test/lang/c/global_variables/TestGlobalVariables.py lldb/packages/Python/lldbsuite/test/python_api/watchpoint/condition/TestWatchpointConditionAPI.py lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteSingleStep.py lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemote_vCont.py Removed: ################################################################################ diff --git a/lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/command/TestWatchpointCommandLLDB.py b/lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/command/TestWatchpointCommandLLDB.py index 6be661943b05..08d220dabc33 100644 --- a/lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/command/TestWatchpointCommandLLDB.py +++ b/lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/command/TestWatchpointCommandLLDB.py @@ -31,11 +31,6 @@ def setUp(self): self.exe_name = 'a%d.out' % self.test_number self.d = {'CXX_SOURCES': self.source, 'EXE': self.exe_name} - @expectedFailureAll( - oslist=["linux"], - archs=["aarch64"], - triple=no_match(".*-android"), - bugnumber="llvm.org/pr27710") # work on android def test_watchpoint_command(self): """Test 'watchpoint command'.""" self.build(dictionary=self.d) @@ -97,11 +92,6 @@ def test_watchpoint_command(self): self.expect("frame variable --show-globals cookie", substrs=['(int32_t)', 'cookie = 777']) - @expectedFailureAll( - oslist=["linux"], - archs=["aarch64"], - triple=no_match(".*-android"), - bugnumber="llvm.org/pr27710") # work on android def test_watchpoint_command_can_disable_a_watchpoint(self): """Test that 'watchpoint command' action can disable a watchpoint after it is triggered.""" self.build(dictionary=self.d) diff --git a/lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/command/TestWatchpointCommandPython.py b/lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/command/TestWatchpointCommandPython.py index 57a63b3ee5e8..b9a67c6cdc4d 100644 --- a/lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/command/TestWatchpointCommandPython.py +++ b/lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/command/TestWatchpointCommandPython.py @@ -33,11 +33,6 @@ def setUp(self): self.d = {'CXX_SOURCES': self.source, 'EXE': self.exe_name} @skipIfFreeBSD # timing out on buildbot - @expectedFailureAll( - oslist=["linux"], - archs=["aarch64"], - triple=no_match(".*-android"), - bugnumber="llvm.org/pr27710") # work on android def test_watchpoint_command(self): """Test 'watchpoint command'.""" self.build(dictionary=self.d) @@ -101,11 +96,6 @@ def test_watchpoint_command(self): substrs=['(int32_t)', 'cookie = 777']) @skipIfFreeBSD # timing out on buildbot - @expectedFailureAll( - oslist=["linux"], - archs=["aarch64"], - triple=no_match(".*-android"), - bugnumber="llvm.org/pr27710") # work on android def test_continue_in_watchpoint_command(self): """Test continue in a watchpoint command.""" self.build(dictionary=self.d) diff --git a/lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/condition/TestWatchpointConditionCmd.py b/lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/condition/TestWatchpointConditionCmd.py index 2a60dfabbe82..e456b2b57c3d 100644 --- a/lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/condition/TestWatchpointConditionCmd.py +++ b/lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_commands/condition/TestWatchpointConditionCmd.py @@ -31,11 +31,6 @@ def setUp(self): self.exe_name = self.testMethodName self.d = {'CXX_SOURCES': self.source, 'EXE': self.exe_name} - @expectedFailureAll( - oslist=["linux"], - archs=["aarch64"], - triple=no_match(".*-android"), - bugnumber="llvm.org/pr27710") def test_watchpoint_cond(self): """Test watchpoint condition.""" self.build(dictionary=self.d) diff --git a/lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_events/TestWatchpointEvents.py b/lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_events/TestWatchpointEvents.py index 6bd238786221..b5bb6c6350b5 100644 --- a/lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_events/TestWatchpointEvents.py +++ b/lldb/packages/Python/lldbsuite/test/commands/watchpoints/watchpoint_events/TestWatchpointEvents.py @@ -20,11 +20,6 @@ def setUp(self): self.main_source = "main.c" @add_test_categories(['pyapi']) - @expectedFailureAll( - oslist=["linux"], - archs=["aarch64"], - triple=no_match(".*-android"), - bugnumber="llvm.org/pr27710") def test_with_python_api(self): """Test that adding, deleting and modifying watchpoints sends the appropriate events.""" self.build() diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/archives/TestBSDArchives.py b/lldb/packages/Python/lldbsuite/test/functionalities/archives/TestBSDArchives.py index eb3eefaa4e74..eca71c056a06 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/archives/TestBSDArchives.py +++ b/lldb/packages/Python/lldbsuite/test/functionalities/archives/TestBSDArchives.py @@ -23,12 +23,6 @@ def setUp(self): @expectedFailureAll( oslist=["windows"], bugnumber="llvm.org/pr24527. Makefile.rules doesn't know how to build static libs on Windows") - @expectedFailureAll( - oslist=["linux"], - archs=[ - "arm", - "aarch64"], - bugnumber="llvm.org/pr27795") def test(self): """Break inside a() and b() defined within libfoo.a.""" self.build() diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py b/lldb/packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py index b2e6dadfe31f..36fdc8622948 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py +++ b/lldb/packages/Python/lldbsuite/test/functionalities/inferior-assert/TestInferiorAssert.py @@ -72,9 +72,7 @@ def test_inferior_asserting_python(self): bugnumber="llvm.org/pr21793: need to implement support for detecting assertion / abort on Windows") @expectedFailureAll( oslist=["linux"], - archs=[ - "aarch64", - "arm"], + archs=["arm"], triple=no_match(".*-android"), bugnumber="llvm.org/pr25338") @expectedFailureAll(bugnumber="llvm.org/pr26592", triple='^mips') @@ -89,9 +87,7 @@ def test_inferior_asserting_expr(self): bugnumber="llvm.org/pr21793: need to implement support for detecting assertion / abort on Windows") @expectedFailureAll( oslist=["linux"], - archs=[ - "aarch64", - "arm"], + archs=["arm"], triple=no_match(".*-android"), bugnumber="llvm.org/pr25338") @expectedFailureAll(bugnumber="llvm.org/pr26592", triple='^mips') diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py b/lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py index 687fb0e7a5e8..2b432e56a740 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py +++ b/lldb/packages/Python/lldbsuite/test/functionalities/tail_call_frames/thread_step_out_or_return/TestSteppingOutWithArtificialFrames.py @@ -71,8 +71,6 @@ def test_stepping_out_past_artificial_frame(self): self.assertFalse(frame2.IsArtificial()) @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr26265") - @expectedFailureAll(archs=["aarch64"], oslist=["linux"], - bugnumber="llvm.org/pr44160") def test_return_past_artificial_frame(self): self.build() thread = self.prepare_thread() diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentTwoWatchpointsOneSignal.py b/lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentTwoWatchpointsOneSignal.py index 51260c7c5caf..808593710770 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentTwoWatchpointsOneSignal.py +++ b/lldb/packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/TestConcurrentTwoWatchpointsOneSignal.py @@ -15,7 +15,6 @@ class ConcurrentTwoWatchpointsOneSignal(ConcurrentEventsBase): @skipIfFreeBSD # timing out on buildbot # Atomic sequences are not supported yet for MIPS in LLDB. @skipIf(triple='^mips') - @expectedFailureAll(bugnumber="llvm.org/pr35228", archs=["arm", "aarch64"]) @expectedFailureNetBSD @add_test_categories(["watchpoint"]) def test(self): diff --git a/lldb/packages/Python/lldbsuite/test/lang/c/const_variables/TestConstVariables.py b/lldb/packages/Python/lldbsuite/test/lang/c/const_variables/TestConstVariables.py index 597790810063..5aacd67a0671 100644 --- a/lldb/packages/Python/lldbsuite/test/lang/c/const_variables/TestConstVariables.py +++ b/lldb/packages/Python/lldbsuite/test/lang/c/const_variables/TestConstVariables.py @@ -24,13 +24,6 @@ class ConstVariableTestCase(TestBase): compiler="clang", compiler_version=["=", "3.8"]) @expectedFailureAll(oslist=["freebsd", "linux"], compiler="icc") @expectedFailureAll(archs=['mips', 'mipsel', 'mips64', 'mips64el']) - @expectedFailureAll( - oslist=["linux"], - archs=[ - 'arm', - 'aarch64'], - triple=no_match(".*-android"), - bugnumber="llvm.org/pr27883") @expectedFailureAll( oslist=["windows"], bugnumber="llvm.org/pr24489: Name lookup not working correctly on Windows") diff --git a/lldb/packages/Python/lldbsuite/test/lang/c/global_variables/TestGlobalVariables.py b/lldb/packages/Python/lldbsuite/test/lang/c/global_variables/TestGlobalVariables.py index 61657e751fd2..4956744a84bb 100644 --- a/lldb/packages/Python/lldbsuite/test/lang/c/global_variables/TestGlobalVariables.py +++ b/lldb/packages/Python/lldbsuite/test/lang/c/global_variables/TestGlobalVariables.py @@ -22,10 +22,6 @@ def setUp(self): self.shlib_names = ["a"] @expectedFailureAll(oslist=["windows"], bugnumber="llvm.org/pr24764") - @expectedFailureAll(oslist=["linux"], - archs=["aarch64"], - triple=no_match(".*-android"), - bugnumber="llvm.org/pr37301") def test_without_process(self): """Test that static initialized variables can be inspected without process.""" diff --git a/lldb/packages/Python/lldbsuite/test/python_api/watchpoint/condition/TestWatchpointConditionAPI.py b/lldb/packages/Python/lldbsuite/test/python_api/watchpoint/condition/TestWatchpointConditionAPI.py index a92de236c07c..e6935dbb48d0 100644 --- a/lldb/packages/Python/lldbsuite/test/python_api/watchpoint/condition/TestWatchpointConditionAPI.py +++ b/lldb/packages/Python/lldbsuite/test/python_api/watchpoint/condition/TestWatchpointConditionAPI.py @@ -31,11 +31,6 @@ def setUp(self): self.exe_name = self.testMethodName self.d = {'CXX_SOURCES': self.source, 'EXE': self.exe_name} - @expectedFailureAll( - oslist=["linux"], - archs=["aarch64"], - triple=no_match(".*-android"), - bugnumber="llvm.org/pr27710") def test_watchpoint_cond_api(self): """Test watchpoint condition API.""" self.build(dictionary=self.d) diff --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteSingleStep.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteSingleStep.py index 205f49bbdf76..f85919adff38 100644 --- a/lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteSingleStep.py +++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteSingleStep.py @@ -29,9 +29,7 @@ def test_single_step_only_steps_one_instruction_with_s_debugserver(self): "aarch64"]) @expectedFailureAll( oslist=["linux"], - archs=[ - "arm", - "aarch64"], + archs=["arm"], bugnumber="llvm.org/pr24739") @skipIf(triple='^mips') def test_single_step_only_steps_one_instruction_with_s_llgs(self): diff --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemote_vCont.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemote_vCont.py index 22265de40de4..bbe2118bbed7 100644 --- a/lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemote_vCont.py +++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemote_vCont.py @@ -114,9 +114,7 @@ def test_single_step_only_steps_one_instruction_with_Hc_vCont_s_debugserver( "aarch64"]) @expectedFailureAll( oslist=["linux"], - archs=[ - "arm", - "aarch64"], + archs=["arm"], bugnumber="llvm.org/pr24739") @skipIf(triple='^mips') @expectedFailureAll(oslist=["ios", "tvos", "watchos", "bridgeos"], bugnumber="rdar://27005337") @@ -146,9 +144,7 @@ def test_single_step_only_steps_one_instruction_with_vCont_s_thread_debugserver( "aarch64"]) @expectedFailureAll( oslist=["linux"], - archs=[ - "arm", - "aarch64"], + archs=["arm"], bugnumber="llvm.org/pr24739") @skipIf(triple='^mips') @expectedFailureAll(oslist=["ios", "tvos", "watchos", "bridgeos"], bugnumber="rdar://27005337") _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
