shafik added subscribers: clayborg, shafik. shafik added a comment. In D70846#1763802 <https://reviews.llvm.org/D70846#1763802>, @teemperor wrote:
> This LGTM, but the TODO directly above the change in > ClangExpressionDeclMap.cpp worries me a bit. I am not sure how good our test > coverage is for calling functions when there are instance methods in scope > (e.g., we are in instance method and try to call another instance method). The comment was added by this change <https://github.com/llvm/llvm-project/commit/308a3c54121fec25edab8aef6d3d6864f62dec2a> I am concerned about regressions since we are not sure how well this is covered. ================ Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp:1213 - target->GetImages().FindFunctions(name, eFunctionNameTypeFull, + target->GetImages().FindFunctions(name, eFunctionNameTypeFull | eFunctionNameTypeBase, include_symbols, include_inlines, ---------------- I did some archeology here and this was changed from `eFunctionNameTypeBase` to `eFunctionNameTypeFull` by [this change](https://github.com/llvm/llvm-project/commit/43fe217b119998264be04a773c4770592663c306) so maybe @clayborg can chime in here. Although it was a while ago. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70846/new/ https://reviews.llvm.org/D70846 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
