clayborg added a comment.

The other fix would be to add a new LLDB API function:

  lldb::SBModule lldb::SBTarget::SetExecutable(const char *path, const char 
*triple, const char *symfile);

Where we would pass in "nullptr" for "triple" and "symfile" from lldb-vscode 
and we call that. But I do think fix SBTarget::AddModule to "do the right 
thing" is a good fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70847/new/

https://reviews.llvm.org/D70847



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to