labath added inline comments.
================
Comment at: lldb/source/Commands/CommandObjectTarget.cpp:4059
if (!module_spec.GetFileSpec() && !module_spec.GetPlatformFileSpec())
- module_spec.GetFileSpec().GetFilename() = symbol_fspec.GetFilename();
+ module_spec.GetFileSpec() = symbol_fspec;
}
----------------
This does change behavior because previously the symbol file directory wasn't
being copied. I think that was intentional because the comment on line 4112
says "match up the file by basename" (and it also makes sense because if you're
adding symbols in an external file, then the main module file cannot be the
exact same path as the symbol file).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70458/new/
https://reviews.llvm.org/D70458
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
