kwk accepted this revision. kwk added a comment. This revision is now accepted and ready to land.
LGTM with the exception of a local variable name. ================ Comment at: lldb/source/Commands/CommandObjectTarget.cpp:2008 uint32_t num_dumped = 0; + Mangled::NamePreference preference = + (m_options.m_prefer_mangled ? Mangled::ePreferMangled ---------------- How about calling this variable `name_preference`? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69944/new/ https://reviews.llvm.org/D69944 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits