jasonmolenda added a comment. I'll be honest I'm having trouble thinking of all the possible problems these regexes might have just by looking at them, but overall this looks good to me.
Should we add a couple of extra file-check tests for variations in the version number part of the binary list in a crash report? Looking around some random crash reports, I see number-number "(6.9 - 1674.102)" I see one where the framework name is in there "(1.11 - FrameworkName 1.11)" and hah a random hand built lldb crash I have on my system has "(7.0.0svn - 7.0.0svn)". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69871/new/ https://reviews.llvm.org/D69871 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
