labath accepted this revision. labath added a comment. This revision is now accepted and ready to land.
LGTM. Thanks for doing this. ================ Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.cpp:17 +// implementing any of the readline module methods. This is meant to +// work around LLVM pr18841 to avoid seg faults in the stock Python +// readline.so linked against GNU readline. ---------------- Maybe also link the python bug/PR here? IIUC, this is something that would be better fixed on the python side... ================ Comment at: lldb/source/Plugins/ScriptInterpreter/Python/PythonReadline.h:13-15 +#ifndef LLDB_DISABLE_LIBEDIT +extern "C" PyMODINIT_FUNC initlldb_readline(void); +#endif ---------------- serge-sans-paille wrote: > labath wrote: > > How about if this file just exposes a single function like > > `WorkAroundLibeditIncompatibilityIfNeeded`? Then this function can be just > > a no-op if no work is needed, and there's no need for messy ifdefs > > anywhere... > I somehow achieved the same by centralizing the messy ifdefs in one explicit > name :-) Ok, that works for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69793/new/ https://reviews.llvm.org/D69793 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
