labath added reviewers: labath, mgorny, sgraenitz.
labath added a comment.

This looks reasonable to me. I'm just wondering, now that these are separate 
targets, I guess that means they can be run in random order, right? Will that 
cause any problems, for instance when creating a package and its subpackage 
(formatters and formatters/cpp maybe)?



================
Comment at: lldb/CMakeLists.txt:133
+  add_copy_file_target(lldb_python_init
+    FILES          "${lldb_scripts_dir}/lldb.py"
+    DEST_DIR       "${lldb_python_build_path}"
----------------
Would it be possible to just make the swig step place this file into the 
correct place directly?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69589/new/

https://reviews.llvm.org/D69589



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to