lawrence_danna marked 4 inline comments as done.
lawrence_danna added inline comments.
================
Comment at:
lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:76-79
+#pragma clang diagnostic push
+#pragma clang diagnostic ignored "-Wreturn-type-c-linkage"
+
+extern "C" llvm::Expected<bool> LLDBSwigPythonBreakpointCallbackFunction(
----------------
labath wrote:
> How sure are we that these functions need to be `extern "C"` ? AFAICT, the
> only requirement is that they match the declarations in
> ScriptInterpreterPython.cpp. That can be easily achieved by just removing
> `extern "C"` from both declarations.
Looks like SWIG forces them to be extern "C".
================
Comment at:
lldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp:2283
+ [&](PythonException &E) {
+ debugger.GetErrorStream() << E.ReadBacktrace();
+ },
----------------
labath wrote:
> Random idea: Should we make `PythonException::message()` include the
> backtrace?
Huh, I don't know. Maybe?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69468/new/
https://reviews.llvm.org/D69468
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
